Remove md array: it is not used any more. #2679
Closed
+69
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you comment on red cross from travis? The one with "boring" tests of course... |
|
Checking it. It should be possible to reproduce it with our own signature algorithms tests. |
snhenson
force-pushed
the
rm_md_array
branch
from
22026ef
to
9c868fd
Compare
snhenson
force-pushed
the
rm_md_array
branch
from
9c868fd
to
69b989c
Compare
|
Finally got this one to pass all the tests. It ended up a bit messier than I hoped but a later tidy up/overhaul of tls1_check_chain() should improve things a lot. |
richsalz
suggested changes
Feb 21, 2017
| for (i = 0; i < SSL_PKEY_NUM; i++) { | ||
| s->s3->tmp.md[i] = NULL; | ||
| /* Clear certificate validity flags */ | ||
| for (i = 0; i < SSL_PKEY_NUM; i++) | ||
| s->s3->tmp.valid_flags[i] = 0; |
There was a problem hiding this comment.
Every time I see this kind of thing, I weep. :)
{ declare uint32_t *fp; }
for (fp = s->s3->tmp.valid_flags, i = SSL_PKEY_NUM; --i >= 0; fp++)
*fp = 0;
Back when things like this counted ... :)
There was a problem hiding this comment.
I used to do that a lot. Compilers can presumably optimise that kind of thing automaticaly these days.
At some point valid_flags is going to go away anyway.
ssl/t1_lib.c
Outdated
| */ | ||
| if (s->s3->tmp.peer_sigalgs == NULL) { | ||
| const uint16_t *sent_sigs; | ||
| size_t sent_sigslen; |
Set default validity flags if signature algorithms extension is not present. Preserve flags when checking chains.
snhenson
force-pushed
the
rm_md_array
branch
from
69b989c
to
86c2187
Compare
|
+1 |
richsalz
approved these changes
Feb 21, 2017
levitte
pushed a commit
that referenced
this pull request
Feb 21, 2017
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2679)
levitte
pushed a commit
that referenced
this pull request
Feb 21, 2017
Set default validity flags if signature algorithms extension is not present. Preserve flags when checking chains. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2679)
levitte
pushed a commit
that referenced
this pull request
Feb 21, 2017
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2679)
levitte
pushed a commit
that referenced
this pull request
Feb 21, 2017
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
This removes the md array. The changes to signature algorithm handling mean it is no longer used.