Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default value of the private key size in the man page #2754

Closed
wants to merge 1 commit into from
Closed

Fixed default value of the private key size in the man page #2754

wants to merge 1 commit into from

Conversation

AdrianVollmer
Copy link

Checklist
  • documentation is added or updated
Description of change

When you generate an RSA key, the default private key size is actually 2048 bits, as is defined in apps/genrsa.c on line 29. The man page still says 512.

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Feb 27, 2017
@richsalz richsalz self-assigned this Feb 27, 2017
@richsalz richsalz added branch: 1.0.2 Merge to OpenSSL_1_0_2-stable branch 1.1.0 branch: master Merge to master branch labels Feb 27, 2017
@richsalz
Copy link
Contributor

@AdrianVollmer can you add "CLA: trivial" to your commit message (do ```git commit --am ; git push -f````) or sign our CLA? Thanks.

…the man page to reflect the actual default (2048 instead of 512)
@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Feb 27, 2017
@AdrianVollmer
Copy link
Author

@richsalz done

@richsalz richsalz removed the hold: cla required The contributor needs to submit a license agreement label Feb 27, 2017
@levitte levitte added the approval: done This pull request has the required number of approvals label Feb 27, 2017
levitte pushed a commit that referenced this pull request Feb 27, 2017
...in the man page to reflect the actual default (2048 instead of 512)

CLA: trivial
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #2754)
levitte pushed a commit that referenced this pull request Feb 27, 2017
...in the man page to reflect the actual default (2048 instead of 512)

CLA: trivial
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #2754)

(cherry picked from commit 013bc44)
levitte pushed a commit that referenced this pull request Feb 27, 2017
...in the man page to reflect the actual default (2048 instead of 512)

CLA: trivial
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #2754)

(cherry picked from commit 013bc44)
@richsalz
Copy link
Contributor

OpenSSL_1_0_2-stable 0da68ec
OpenSSL_1_1_0-stable d0c278e
master 013bc44

thanks!

@richsalz richsalz closed this Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 1.0.2 Merge to OpenSSL_1_0_2-stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants