Fix no-tls1_2 and no-dtls1_2 #2788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
reviewed
Feb 28, 2017
| ADD_TEST(test_early_cb); | ||
| #endif |
There was a problem hiding this comment.
So... this works with SSL v3, TLS v1.0, v1.1 and v1.3, but not v1.2?
There was a problem hiding this comment.
No - this test only works if we have v1.2, i.e. if 1.2 is disabled we shouldn't run it. It uses some 1.2 only ciphersuites.
There was a problem hiding this comment.
I read the directive wrong, sorry. Thanks for explaining.
levitte
approved these changes
Feb 28, 2017
levitte
added
the
approval: done
|
Pushed. Thanks. |
levitte
pushed a commit
that referenced
this pull request
Feb 28, 2017
Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #2788)
levitte
pushed a commit
that referenced
this pull request
Feb 28, 2017
Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #2788)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
This fixes no-tls1_2 and no-dtls1_2 configurations. The commit changing sslapitest is for master only. The other commit is for both master and 1.1.0.