New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openssl uefi #2961
Openssl uefi #2961
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -279,9 +279,10 @@ MSG_PROCESS_RETURN tls_process_cert_verify(SSL *s, PACKET *pkt) | |
const unsigned char *data; | ||
#ifndef OPENSSL_NO_GOST | ||
unsigned char *gost_data = NULL; | ||
int pktype; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm sorry, I misled you regarding this one. There's now an There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Exactly. I also didn't notice this issue. So moving the gost_data declaration to the original position. |
||
#endif | ||
int al = SSL_AD_INTERNAL_ERROR, ret = MSG_PROCESS_ERROR; | ||
int type = 0, j, pktype; | ||
int type = 0, j; | ||
unsigned int len; | ||
X509 *peer; | ||
const EVP_MD *md = NULL; | ||
|
@@ -303,7 +304,6 @@ MSG_PROCESS_RETURN tls_process_cert_verify(SSL *s, PACKET *pkt) | |
goto f_err; | ||
} | ||
|
||
pktype = EVP_PKEY_id(pkey); | ||
type = X509_certificate_type(peer, pkey); | ||
|
||
if (!(type & EVP_PKT_SIGN)) { | ||
|
@@ -384,6 +384,7 @@ MSG_PROCESS_RETURN tls_process_cert_verify(SSL *s, PACKET *pkt) | |
} | ||
#ifndef OPENSSL_NO_GOST | ||
{ | ||
pktype = EVP_PKEY_id(pkey); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change this line to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's possible that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's OK for me to move them to the position of first usage. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we don't have any strong rules. we try to move things to an inner block if possible, but we don't create blocks just to limit variable scope. |
||
if (pktype == NID_id_GostR3410_2001 | ||
|| pktype == NID_id_GostR3410_2012_256 | ||
|| pktype == NID_id_GostR3410_2012_512) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line.