Correct tls1.3-draft19 intermediate secret derivation #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This label for this derivation was incorrectly "derived" or "der" depending on the pointer size of the build(!). The correct string is "derived secret".
These were still generated by openssl, but with the previous commit are corroborated by rustls.
t-j-h
approved these changes
Mar 19, 2017
|
Note this assumes @snhenson or @mattcaswell can confirm the test case changes - I just reviewed the actual code change itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Prior to this change, openssl truncated the label
"derived secret"to 7 or 3 bytes by mistake (depending on the host's pointer size). The problem was the usualsizeof(ptr-to-char)vssizeof(char[])confusion.With this change in place, I can handshake with another draft19 implementation. I've regenerated the tests, and corroborated those values with the other implementation.