Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't access memory before checking the correct length in e_aes_hmac_sha256.c #3023

Closed
wants to merge 1 commit into from
Closed

Don't access memory before checking the correct length in e_aes_hmac_sha256.c #3023

wants to merge 1 commit into from

Conversation

bernd-edlinger
Copy link
Member

Works for master and 1.1.0 but needs some handwork for 1.0.2

@bernd-edlinger
Don't access memory before checking the correct length in
3da26c3 
aesni_cbc_hmac_sha256_ctrl in case EVP_CTRL_AEAD_TLS1_AAD.
dot-asm
dot-asm approved these changes Mar 24, 2017
View reviewed changes
Copy link
Contributor

@dot-asm dot-asm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@dot-asm dot-asm added 1.1.0 branch: master Merge to master branch labels Mar 24, 2017
@bernd-edlinger bernd-edlinger mentioned this pull request Mar 24, 2017
Closed
@levitte levitte added the approval: done This pull request has the required number of approvals label Mar 24, 2017
levitte pushed a commit that referenced this pull request Mar 25, 2017
@bernd-edlinger
Don't access memory before checking the correct length in aesni_cbc_h…
1b6f5a4 
…mac_sha256_ctrl in case EVP_CTRL_AEAD_TLS1_AAD.

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #3023)
levitte pushed a commit that referenced this pull request Mar 25, 2017
@bernd-edlinger
Don't access memory before checking the correct length in aesni_cbc_h…
2ba62f0 
…mac_sha256_ctrl in case EVP_CTRL_AEAD_TLS1_AAD.

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #3023)

(cherry picked from commit 1b6f5a4)
@dot-asm
Copy link
Contributor

dot-asm commented Mar 25, 2017

Merged. Thanks for report/request!

@dot-asm dot-asm closed this Mar 25, 2017
pracj3am pushed a commit to cdn77/openssl that referenced this pull request Aug 22, 2017
@bernd-edlinger @pracj3am
Don't access memory before checking the correct length in aesni_cbc_h…
e3bc670 
…mac_sha256_ctrl in case EVP_CTRL_AEAD_TLS1_AAD.

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from openssl#3023)

(cherry picked from commit 1b6f5a4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@dot-asm dot-asm dot-asm approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bernd-edlinger @dot-asm @levitte