Fixed a gcc-7-strict-warnings issue. #3026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dot-asm
approved these changes
Mar 24, 2017
levitte
approved these changes
Mar 24, 2017
dot-asm
added
branch: 1.0.2
|
@dot-asm, I assume this can go to all active branches, not just the 1.0.2 one. @bernd-edlinger seems to work mainly from the 1.0.2 branch, though... |
|
Never mind, I just discovered I assumed wrong |
levitte
pushed a commit
that referenced
this pull request
Mar 25, 2017
Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #3026)
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC-7 assumes len can be negative, and emits a warning here.
It can be fixed by moving the memcpy in to the if block.
This is the same as this function works on master.