Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant redeclaration of ‘X509_STORE_set_flags’ #3047

Closed
wants to merge 1 commit into from
Closed

Remove redundant redeclaration of ‘X509_STORE_set_flags’ #3047

wants to merge 1 commit into from

Conversation

bjori
Copy link
Contributor

@bjori bjori commented Mar 27, 2017

a47bc28 accidentally adds another define for X509_STORE_set_flags
It is already defined 5 lines prior

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Mar 27, 2017
@richsalz
Copy link
Contributor

@bjori, we need you to either sign our CLA, or put "CLA: trivial" in your commit message. Thanks.

@richsalz richsalz added the 1.1.0 label Mar 28, 2017
@richsalz richsalz self-assigned this Mar 28, 2017
@richsalz richsalz added the branch: master Merge to master branch label Mar 28, 2017
@bjori
Remove redundant redeclaration of ‘X509_STORE_set_flags’
3f36589 
a47bc28 accidentally adds another define for X509_STORE_set_flags
It is already defined 5lines prior

CLA: trivial
@bjori
Copy link
Contributor Author

bjori commented Mar 28, 2017

I've amended the commit message to add CLA: trivial

@levitte levitte added approval: done This pull request has the required number of approvals and removed hold: cla required The contributor needs to submit a license agreement labels Mar 28, 2017
@levitte
Copy link
Member

levitte commented Mar 28, 2017

Formality: I agree this is trivial. @t-j-h, we need this formality from you too.

@levitte levitte removed the approval: done This pull request has the required number of approvals label Mar 28, 2017
levitte pushed a commit that referenced this pull request Mar 28, 2017
@bjori
Remove redundant decl of 509_STORE_set_flags
231fa2b 
a47bc28 accidentally adds another define for X509_STORE_set_flags
It is already defined 5lines prior

CLA: trivial

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #3047)

(cherry picked from commit feb8919)
levitte pushed a commit that referenced this pull request Mar 28, 2017
@bjori
Remove redundant decl of 509_STORE_set_flags
feb8919 
a47bc28 accidentally adds another define for X509_STORE_set_flags
It is already defined 5lines prior

CLA: trivial

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #3047)
@richsalz
Copy link
Contributor

i agree :) merged to master and 1.1.0, thanks!

1 similar comment
@richsalz
Copy link
Contributor

i agree :) merged to master and 1.1.0, thanks!

@richsalz richsalz closed this Mar 28, 2017
pracj3am pushed a commit to cdn77/openssl that referenced this pull request Aug 22, 2017
@bjori @pracj3am
Remove redundant decl of 509_STORE_set_flags
6d902af 
a47bc28 accidentally adds another define for X509_STORE_set_flags
It is already defined 5lines prior

CLA: trivial

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from openssl#3047)

(cherry picked from commit feb8919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@t-j-h t-j-h t-j-h approved these changes

Assignees

@richsalz richsalz

Labels
branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bjori @richsalz @levitte @t-j-h @openssl-machine