Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMS: Fix the passing of cflags for things not being installed #3247

Closed
wants to merge 2 commits into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Apr 18, 2017

When building object files for libraries, information whether the
library would be installed or not wasn't passed down to the object
file building rules.

Also, make it so settings like |no_inst_lib_cflags| can be the empty
string.

When building object files for libraries, information whether the
library would be installed or not wasn't passed down to the object
file building rules.

Also, make it so settings like |no_inst_lib_cflags| can be the empty
string.
@levitte levitte added the branch: master Merge to master branch label Apr 18, 2017
@levitte levitte changed the title VMS: Fix the passing of cflags for things not being installed WIP: VMS: Fix the passing of cflags for things not being installed Apr 18, 2017
@levitte
Copy link
Member Author

levitte commented Apr 18, 2017

WIP until all tests apps this breaks are repaired

The internals test programs access header files that aren't guarded by
the public __DECC_INCLUDE_PROLOGUE.H and __DECC_INCLUDE_EPILOGUE.H files,
and therefore have no idea what the naming convention is.  Therefore, we
need to specify that explicitely in the internals test programs, since
they aren't built with the same naming convention as the library they
belong with.
@levitte levitte changed the title WIP: VMS: Fix the passing of cflags for things not being installed VMS: Fix the passing of cflags for things not being installed Apr 18, 2017
@levitte
Copy link
Member Author

levitte commented Apr 18, 2017

All internals test programs fixed up.

@levitte levitte added the approval: done This pull request has the required number of approvals label Apr 18, 2017
@levitte
Copy link
Member Author

levitte commented Apr 18, 2017

Merged. 19eaee7 to edd689e

Thanks!

@levitte levitte closed this Apr 18, 2017
levitte added a commit that referenced this pull request Apr 18, 2017
When building object files for libraries, information whether the
library would be installed or not wasn't passed down to the object
file building rules.

Also, make it so settings like |no_inst_lib_cflags| can be the empty
string.

Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #3247)
levitte added a commit that referenced this pull request Apr 18, 2017
The internals test programs access header files that aren't guarded by
the public __DECC_INCLUDE_PROLOGUE.H and __DECC_INCLUDE_EPILOGUE.H files,
and therefore have no idea what the naming convention is.  Therefore, we
need to specify that explicitely in the internals test programs, since
they aren't built with the same naming convention as the library they
belong with.

Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #3247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants