[1.1.0] Add a 'max_send_frag' option to configure maximum size of send fragments #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FdaSilvaYY
changed the title
|
This looks like you want to add a new feature to a stable branch. What is the justification? |
|
Hi, |
FdaSilvaYY
force-pushed
the
Pick-3141
branch
2 times, most recently
from
0be81da
to
564b59c
Compare
|
What's the relationship between this and #1008 ? |
|
No relation...
#1008 internally relies on the 'max send frag' implementation, but this PR has nothing to see with it.
This PR is for 1.1.0.
… Le 9 juin 2017 à 19:35, Rich Salz ***@***.***> a écrit :
What's the relationship between this and #1008 ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from openssl#3141) cherry-pick from 28e5ea8
Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from openssl#3141) Cherry-oick from 6788785
Remove hardcoded bound checkings. Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from openssl#3141) cherry-pick from 36b2cfb
|
This looks like a new feature going into 1.1.0, so I think not appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3141: add missing options
Checklist