Ignore -named_curve auto value to improve backwards compatibility #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richsalz
suggested changes
May 22, 2017
ssl/ssl_conf.c
Outdated
| /* Ignore values supported by 1.0.2 for the automatic selection */ | ||
| if ((cctx->flags & SSL_CONF_FLAG_FILE) && !strcasecmp(value, "+automatic")) | ||
| return 1; | ||
| else if ((cctx->flags & SSL_CONF_FLAG_CMDLINE) && !strcmp(value, "auto")) |
There was a problem hiding this comment.
oops, sorry, and explicitly test against zero, don't use !
|
Updated patch |
mattcaswell
approved these changes
Jun 8, 2017
|
Ping @richsalz |
richsalz
approved these changes
Jun 8, 2017
|
fnx for the nudge. |
|
Pushed. Thanks. |
pracj3am
pushed a commit
to cdn77/openssl
that referenced
this pull request
Aug 22, 2017
Fixes openssl#3490 Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl#3518) (cherry picked from commit 1c7aa0d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3490
Checklist