aria/aria.c: address undefined behaviour warning in small-footprint path. #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[extended tests]
dot-asm
changed the title
|
Red cross from travis is unrelated, ready to go. |
richsalz
approved these changes
May 26, 2017
richsalz
added
the
approval: done
levitte
pushed a commit
that referenced
this pull request
May 26, 2017
…ath. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #3526)
levitte
pushed a commit
that referenced
this pull request
May 26, 2017
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #3526)
|
Merged. BTW, one argue that second commit, one addressing ubsan warning in ocb128.c, should be cherry-picked to 1.1.0. I mean I suggest we do so. Any objections? |
dot-asm
added
1.1.0
and removed
approval: done
|
If this applies to older branches, feel free to apply it to them too. |
pracj3am
pushed a commit
to cdn77/openssl
that referenced
this pull request
Aug 22, 2017
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from openssl#3526) (cherry picked from commit 14bb100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip ci]
I mark it with [skip ci] for the moment, because clang 3.9 ubsan complains even about OCB [which is not related]. Next commit addressing it would have [extended tests] instead. In other words it's not something that can be approved yet...
Related ticket is #3242.