Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line numbering for errors. #3528

Closed
wants to merge 1 commit into from
Closed

Fix line numbering for errors. #3528

wants to merge 1 commit into from

Conversation

richsalz
Copy link
Contributor

Mentioned in comment in #3506

@richsalz richsalz mentioned this pull request May 23, 2017
Closed
@dot-asm
Copy link
Contributor

dot-asm commented May 23, 2017

I see no difference. If I corrupt two first A values in bnmul.txt it prints

...
    # INFO: 
    # Failed Square test at 0
...
    # INFO: 
    # Failed Square test at 15
...

Expected 'at' line numbers are 13 and 17.

@richsalz
Copy link
Contributor Author

fixed! Updated commit pushed.

@dot-asm dot-asm added branch: master Merge to master branch approval: done This pull request has the required number of approvals labels May 23, 2017
levitte pushed a commit that referenced this pull request May 23, 2017
Fix line numbering for errors.
281313e 
Reviewed-by: Andy Polyakov <appro@openssl.org>
(Merged from #3528)
@richsalz
Copy link
Contributor Author

thanks for the suggestion and review!

@richsalz richsalz closed this May 23, 2017
@richsalz richsalz deleted the fix-bntest-number branch May 23, 2017 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dot-asm dot-asm dot-asm approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richsalz @dot-asm