Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -p (public only) flag #3603

Closed
wants to merge 2 commits into from
Closed

Add -p (public only) flag #3603

wants to merge 2 commits into from

Conversation

richsalz
Copy link
Contributor

@richsalz richsalz commented Jun 1, 2017

This catches #define's and types. Fixing those (via POD comments) will come in a separate PR.

Report if any non-public items are documented.
Add util/private.num that lists items that aren't in the public
(lib*.num) files that we do want to document.

[skip ci]
@richsalz richsalz changed the title Add -p (public only) flag; not ready for use yet Add -p (public only) flag Jun 1, 2017
@dot-asm dot-asm added branch: master Merge to master branch approval: done This pull request has the required number of approvals labels Jun 1, 2017
@richsalz richsalz self-assigned this Jun 1, 2017
levitte pushed a commit that referenced this pull request Jun 1, 2017
Report if any non-public items are documented.
Add util/private.num that lists items that aren't in the public
(lib*.num) files that we do want to document.

Reviewed-by: Andy Polyakov <appro@openssl.org>
(Merged from #3603)
@richsalz
Copy link
Contributor Author

richsalz commented Jun 1, 2017

274d1be (merged commit) in master. thanks!

@richsalz richsalz closed this Jun 1, 2017
@richsalz richsalz deleted the only-doc-public branch June 1, 2017 20:27
@levitte
Copy link
Member

levitte commented Jun 24, 2017

Isn't util/private.num a weird name, considering it contains information about public symbols?

@richsalz
Copy link
Contributor Author

Yeah, probably. I forget my thinking -- it was stuff thought private? I dunno. Feel free to change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants