Add back support for SHA224 based sig algs #3639
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to work but was inadvertently removed as part of the TLSv1.3 work. This adds it back.
Fixes #3633
Note: It seems we are offering disallowed sig algs in a TLSv1.3 compliant ClientHello (including sha1, and now sha224). Draft-20 says this:
Probably we should only offer sha1/sha224 if TLSv1.3 has been disabled. That would be a different PR though.
Checklist