Implement Camellia GCM suites (RFC 6367) #374
Closed
+861
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to commit 7504878. GH#320
|
Since this is not gonna be merged I'm closing it. I'm tired of keeping this up-to-date for nothing. |
|
D: |
|
This could be merged if it was rebased to the current master. |
|
I think its a non-trivial rebase due to all the provider changes. |
|
Yes, of course. |
|
I added this comment to just indicate to @ghedo if he wanted to spend time rebasing it once again that it would be likely merged. |
mcr
pushed a commit
to mcr/openssl
that referenced
this pull request
Jun 22, 2021
pkey: allow setting algorithm-specific options in #sign and #verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #320.
The EVP Camellia GCM code is mostly the same as the AES one, so maybe there's an opportunity for some refactoring there.