Use randomness not entropy #3773
Conversation
richsalz
added
branch: master
doc/man3/RAND_add.pod
Outdated
| sources of randomness and how to estimate their entropy can be found | ||
| in the literature, e.g. RFC 1750. | ||
| B<randomness> argument is an estimate of how much randomness is contained in | ||
| B<buf> and should be a nujbmer between zero and B<num>. |
There was a problem hiding this comment.
It's no longer saying that it's in bytes, it might also be expressed in bits.
doc/man3/RAND_bytes.pod
Outdated
| The contents of B<buf> is mixed into the entropy pool before retrieving | ||
| the new pseudo-random bytes unless disabled at compile time (see FAQ). | ||
| The contents of B<buf> is mixed into the randomness pool before retrieving | ||
| the new pseudo-random bytes. |
There was a problem hiding this comment.
This is actually no longer the case.
|
Added a commit that addresses your feedback so far, @kroeckx . |
|
ping. i have some more doc fixes to do after this. |
apps/app_rand.c
Outdated
| /* | ||
| * If we did not manage to read the seed file, we should not write a | ||
| * low-entropy seed file back -- it would suppress a crucial warning | ||
| * low-random seed file back -- it would suppress a crucial warning |
There was a problem hiding this comment.
"low-random" doesn't parse as English.
doc/man3/RAND_egd.pod
Outdated
| the EGD entropy gathering daemon can be used to collect entropy. It provides | ||
| a socket interface through which entropy can be gathered in chunks up to | ||
| On systems without /dev/*random devices providing randomness from the kernel, | ||
| EGD. It provides |
There was a problem hiding this comment.
This is not a complete sentence.
|
Added commit with @kaduk's comments addressed. |
apps/app_rand.c
Outdated
| * low-random seed file back -- it would suppress a crucial warning | ||
| * the next time we want to use it. | ||
| * If we didn't manage to read the seed file, don't write a | ||
| * file out -- it would suppress a crucial warning the next |
There was a problem hiding this comment.
side note: FreeBSD documentation style guide says to not use contractions. But of course we can have our own style.
Reviewed-by: Ben Kaduk <kaduk@mit.edu> (Merged from #3773)
|
thanks. |
This PR does not touch the crypto/rand directory which is being handled separately.