Fix compiler warnings #3839
Fix compiler warnings #3839
Conversation
|
Customarily it's argued (well, at least I for one do) that this is compiler bug in warning subsystem. I mean warning about shadowing a variable is useful, but warning about shadowing function is not, essentially counter-productive. And this was apparently recognized as bug, because for example gcc 3.x complains about it, so does 4.6, but not 4.8. And question in the context is, if it's compiler bug, then do we actually have to work around it? However, if we choose to, I'd argue that ctlogp would probably be better replacement name for variable in question... |
|
The change that added this went in on the 10th of June this year so it is recent rather than dusty. Perhaps renaming the variable is prudent. I agree that |
|
+1 @pauli if you want to change to ctlogp |
Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #3839)
|
Thanks. |
I get the following error when I use gcc 4.4.7 with Travis YML plugin and Jenkins :
gcc -Icrypto/include -Iinclude -I../_srcdist/crypto/include -I../_srcdist/include -DDSO_DLFCN -DHAVE_DLFCN_H -DNDEBUG -DOPENSSL_THREADS -DOPENSSL_NO_STATIC_ENGINE -DOPENSSL_PIC -DOPENSSLDIR=""/usr/local/ssl"" -DENGINESDIR=""/usr/local/lib64/engines-1.1"" -Wall -O3 -pthread -m64 -DL_ENDIAN -DDEBUG_UNUSED -Wswitch -DPEDANTIC -pedantic -Wno-long-long -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wsign-compare -Wmissing-prototypes -Wshadow -Wformat -Wtype-limits -Wundef -Werror -MMD -MF test/ct_test.d.tmp -MT test/ct_test.o -c -o test/ct_test.o ../_srcdist/test/ct_test.c
cc1: warnings being treated as errors
../_srcdist/test/ct_test.c: In function 'test_ctlog_from_base64':
../_srcdist/test/ct_test.c:491: error: declaration of 'log' shadows a global declaration
/usr/include/bits/mathcalls.h:110: error: shadowed declaration is here
make[1]: *** [test/ct_test.o] Error 1
This patch fixes the problem.