Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc/ca.pod to clarify description for dates #3895

Closed
wants to merge 1 commit into from
Closed

Update doc/ca.pod to clarify description for dates #3895

wants to merge 1 commit into from

Conversation

InfoHunter
Copy link
Member

"Note" part is based on PR #3566

Checklist
  • documentation is added or updated

FdaSilvaYY
FdaSilvaYY reviewed Jul 9, 2017
View reviewed changes
doc/man1/ca.pod Outdated

Based on RFC 5280, since OpenSSL 1.1.1, the certificate validity period
(specified by any of B<-startdate>, B<-enddate> and B<-days>) will be
enconded as UTCTime if the dates are earlier than 2049 (included), and as
Copy link
Contributor

@FdaSilvaYY FdaSilvaYY Jul 9, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enconded ? ;)
than (year) 2049 ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errr...

@InfoHunter InfoHunter force-pushed the ca-doc branch 2 times, most recently from f8c8c7f to db4b03c Compare July 10, 2017 03:13
@InfoHunter
Copy link
Member Author

commit updated. @FdaSilvaYY

@InfoHunter
Copy link
Member Author

Ping @openssl

kaduk
kaduk reviewed Jul 13, 2017
View reviewed changes
doc/man1/ca.pod Outdated
date is YYMMDDHHMMSSZ (the same as an ASN1 UTCTime structure).
date is YYMMDDHHMMSSZ (the same as an ASN1 UTCTime structure), or
YYYYMMDDHHMMSSZ (the same as an ASN1 GeneralizedTime structure). In
both formats, seconds SS and timzone Z must be presented.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think s/presented/present/ is better.

doc/man1/ca.pod Outdated
date is YYMMDDHHMMSSZ (the same as an ASN1 UTCTime structure).
date is YYMMDDHHMMSSZ (the same as an ASN1 UTCTime structure), or
YYYYMMDDHHMMSSZ (the same as an ASN1 GeneralizedTime structure). In
both formats, seconds SS and timzone Z must be presented.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ditto)

@InfoHunter
Copy link
Member Author

updated: change 'presented' to 'present'

@InfoHunter
Copy link
Member Author

Let'e ping @openssl for an OMC approval.

richsalz
richsalz suggested changes Jul 15, 2017
View reviewed changes
doc/man1/ca.pod Outdated
@@ -701,6 +705,13 @@ For example if the CA certificate has:

then even if a certificate is issued with CA:TRUE it will not be valid.

=head1 NOTE

Based on RFC 5280, since OpenSSL 1.1.1, the certificate validity period
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call this HISTORY and start it as "Since OpenSSL version 1.1.1, the program follows RFC 5280 and ...."

@InfoHunter
Copy link
Member Author

updated based on @richsalz 's comments.

@InfoHunter InfoHunter mentioned this pull request Jul 15, 2017
Closed
@InfoHunter
Copy link
Member Author

Delete 'version' to follow #3938

@InfoHunter
Copy link
Member Author

Please re-confirm, @kaduk @richsalz

@richsalz
Copy link
Contributor

richsalz commented Jul 15, 2017 via email

@dot-asm dot-asm added the approval: done This pull request has the required number of approvals label Jul 16, 2017
@InfoHunter
Copy link
Member Author

looks like this could be merged now...

levitte pushed a commit that referenced this pull request Jul 23, 2017
@InfoHunter
Update doc/ca.pod to clarify description for dates
909873b 
"Note" part is based on PR #3566

Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #3895)
@richsalz
Copy link
Contributor

thank you!

@richsalz richsalz closed this Jul 23, 2017
@InfoHunter InfoHunter deleted the ca-doc branch July 23, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FdaSilvaYY FdaSilvaYY FdaSilvaYY left review comments

@kaduk kaduk kaduk approved these changes

@richsalz richsalz richsalz approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@InfoHunter @richsalz @kaduk @FdaSilvaYY @dot-asm