Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for copy and copy-if-different scripts with whitespace problem #1023 - CLA: trivial #3904

Closed
wants to merge 1 commit into from
Closed

Patch for copy and copy-if-different scripts with whitespace problem #1023 - CLA: trivial #3904

wants to merge 1 commit into from

Conversation

simon-p-r
Copy link

@simon-p-r simon-p-r commented Jul 10, 2017 •
edited

Small "CLA: trivial" fix related to #1023

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Jul 10, 2017
@InfoHunter
Copy link
Member

You may need to add CLA: trivial in your commit message or sign a CLA at: https://www.openssl.org/policies/cla.html, to avoid cla-check failure.

@simon-p-r simon-p-r changed the title Patch for copy and copy-if-different scripts with whitespace problem #1023 Patch for copy and copy-if-different scripts with whitespace problem #1023 - CLA: trivial Jul 11, 2017
@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Jul 11, 2017
@richsalz
Copy link
Contributor

Simon, we need you to put "CLA: trivial" in your commit text (and push -f) or sign our CLA.
I agree this is trivial.
Ping @levitte

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Jul 11, 2017
@simon-p-r
Copy link
Author

@richsalz is that ok?

@InfoHunter
Copy link
Member

Seems you should put the CLA: trivial line into the commit text, not the commit title:

patch for copy and copy-if-different whitespace problem

CLA: trivial

@richsalz
Copy link
Contributor

What @InfoHunter said.

@dot-asm dot-asm added approval: done This pull request has the required number of approvals and removed hold: cla required The contributor needs to submit a license agreement labels Jul 13, 2017
levitte pushed a commit that referenced this pull request Jul 15, 2017
@simon-p-r
fix copy and copy-if-different whitespace problem
b832656 
From #1023

CLA: trivial

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #3904)
@richsalz
Copy link
Contributor

commit b832656 in 1.0.2-stable, thank you!

@richsalz richsalz closed this Jul 15, 2017
@simon-p-r
Copy link
Author

Thanks and no problem

@mattcaswell mattcaswell mentioned this pull request Nov 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richsalz richsalz richsalz approved these changes

@dot-asm dot-asm dot-asm approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@simon-p-r @InfoHunter @richsalz @dot-asm @openssl-machine