Fix use-after-free #3947
Closed
Fix use-after-free #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dot-asm
reviewed
Jul 17, 2017
| @@ -84,7 +85,8 @@ int opt_rand(int opt) | |||
| return loadfiles(opt_arg()); | |||
| break; | |||
| case OPT_R_WRITERAND: | |||
| save_rand_file = opt_arg(); | |||
| OPENSSL_free(save_rand_file); | |||
There was a problem hiding this comment.
If there is situation when OPENSSL_free would be required here, then it would be appropriate to save_rand_file = NULL after line 69. Otherwise we would be looking at double-free. No?
There was a problem hiding this comment.
it's only called on app exit so I don't think so, but it is safer to do so. updated commit pushed
There was a problem hiding this comment.
But you can start openssl without arguments and invoke "apps" or one several times, right?
Also fix a RANDerr call.
dot-asm
approved these changes
Jul 17, 2017
dot-asm
added
the
approval: done
|
Yes but it’s only called on exit as part of process cleanup. But maybe I’m wrong.
|
levitte
pushed a commit
that referenced
this pull request
Jul 17, 2017
Also fix a RANDerr call. Reviewed-by: Andy Polyakov <appro@openssl.org> (Merged from #3947)
|
merged with 5435ba0, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a RANDerr call.
Fixes #3946