Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apps/s_client.c's XMPP client #3981

Conversation

levitte
Copy link
Member

@levitte levitte commented Jul 20, 2017

When an error occurs during the starttls handskake, s_client gets stuck
looping around zero bytes reads, because the server won't sent anything more
after its error tag. Shutting down on the first zero byte read fixes this.

Fixes #3980

When an error occurs during the starttls handskake, s_client gets stuck
looping around zero bytes reads, because the server won't sent anything more
after its error tag.  Shutting down on the first zero byte read fixes this.

Fixes openssl#3980
@levitte levitte added the branch: 1.0.2 Merge to OpenSSL_1_0_2-stable branch label Jul 20, 2017
@richsalz
Copy link
Contributor

Did the original poster confirm this?
+1 either way I guess.

levitte added a commit that referenced this pull request Jul 20, 2017
When an error occurs during the starttls handskake, s_client gets stuck
looping around zero bytes reads, because the server won't sent anything more
after its error tag.  Shutting down on the first zero byte read fixes this.

Fixes #3980

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #3981)
@levitte
Copy link
Member Author

levitte commented Jul 20, 2017

Merged. 56d9098

@levitte levitte closed this Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch: 1.0.2 Merge to OpenSSL_1_0_2-stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants