Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function prototypes #3995

Closed
wants to merge 1 commit into from

Conversation

xiaoyinl
Copy link
Contributor

@xiaoyinl xiaoyinl commented Jul 22, 2017

args_verify() and opt_reset() are declared in apps/apps.h, but they are
not referenced anywhere. So can we remove them from apps.h?

`args_verify()` and `opt_reset()` are declared in `apps/apps.h`, but they are
not referenced anywhere. So can we remove them from `apps.h`?
Copy link
Contributor

@richsalz richsalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kroeckx you going to merge? or me?

@richsalz richsalz added branch: master Merge to master branch approval: done This pull request has the required number of approvals labels Jul 23, 2017
@richsalz richsalz self-assigned this Jul 23, 2017
@richsalz
Copy link
Contributor

I was bored, I did it :) Thanks for the fixes!

@richsalz richsalz closed this Jul 23, 2017
levitte pushed a commit that referenced this pull request Jul 23, 2017
`args_verify()` and `opt_reset()` are declared in `apps/apps.h`, but they are
not referenced anywhere. So can we remove them from `apps.h`?

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #3995)
@xiaoyinl xiaoyinl deleted the rm_prototype branch July 23, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants