Fix leaked password in pkcs8 pkey decrypt #4047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and d2i_PKCS8PrivateKey_bio before it goes out of scope.
bernd-edlinger
added
branch: 1.0.2
richsalz
approved these changes
Jul 29, 2017
richsalz
added
the
approval: done
|
I mean, I'm glad you're going to do that :) |
|
Yes, OK :-) |
levitte
pushed a commit
that referenced
this pull request
Jul 29, 2017
and d2i_PKCS8PrivateKey_bio before it goes out of scope. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #4047)
levitte
pushed a commit
that referenced
this pull request
Jul 29, 2017
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #4047)
|
merged to all branches. |
pracj3am
pushed a commit
to cdn77/openssl
that referenced
this pull request
Aug 22, 2017
and d2i_PKCS8PrivateKey_bio before it goes out of scope. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from openssl#4047) (cherry picked from commit 02fd47c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a pkcs8 private key is decrypted the used password is left on the stack.
As there is zero test coverage, I wanted to have at least one test that executes
this code, so I thought I extend the only test that uses the pkcs8 command.