Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing HTML tag in www_body in s_server.c #4088

Closed
wants to merge 1 commit into from

Conversation

xiaoyinl
Copy link
Contributor

@xiaoyinl xiaoyinl commented Aug 5, 2017

In the generated HTML document, the <pre> tag is not closed (open tag is at Line 3033). This patch also has a trivial code-style improvement, unrelated to the bug fix.

In the generated HTML document, the `<pre>` tag is not closed. This patch also has a trivial code-style improvement, unrelated to the bug fix.
@kroeckx kroeckx added the approval: done This pull request has the required number of approvals label Aug 5, 2017
@xiaoyinl xiaoyinl closed this Aug 6, 2017
@xiaoyinl xiaoyinl reopened this Aug 6, 2017
@kroeckx
Copy link
Member

kroeckx commented Aug 8, 2017

@levitte: Will you merge this?

@richsalz richsalz self-assigned this Aug 9, 2017
@richsalz
Copy link
Contributor

richsalz commented Aug 9, 2017

I'll merge and cherry-pick to 1.1.0 and 1.0.2

@richsalz richsalz added branch: 1.0.2 Merge to OpenSSL_1_0_2-stable branch 1.1.0 labels Aug 9, 2017
levitte pushed a commit that referenced this pull request Aug 9, 2017
In the generated HTML document, the `<pre>` tag is not closed. This patch also has a trivial code-style improvement, unrelated to the bug fix.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #4088)
levitte pushed a commit that referenced this pull request Aug 9, 2017
In the generated HTML document, the `<pre>` tag is not closed. This patch
also has a trivial code-style improvement, unrelated to the bug fix.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #4088)

(cherry picked from commit 1a9f5cf)
levitte pushed a commit that referenced this pull request Aug 9, 2017
In the generated HTML document, the `<pre>` tag is not closed.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #4088)
(cherry picked from commit 1a9f5cf)
@richsalz
Copy link
Contributor

richsalz commented Aug 9, 2017

merged to all three branches, thank you!

@richsalz richsalz closed this Aug 9, 2017
@xiaoyinl xiaoyinl deleted the close_pre branch August 9, 2017 16:25
pracj3am pushed a commit to cdn77/openssl that referenced this pull request Aug 22, 2017
In the generated HTML document, the `<pre>` tag is not closed. This patch
also has a trivial code-style improvement, unrelated to the bug fix.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from openssl#4088)

(cherry picked from commit 1a9f5cf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: 1.0.2 Merge to OpenSSL_1_0_2-stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants