Fix 'key' option in s_server can be in ENGINE keyform (master) #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deemru
changed the title
snhenson
approved these changes
Sep 22, 2017
snhenson
added
the
approval: review pending
paulidale
approved these changes
Sep 23, 2017
levitte
pushed a commit
that referenced
this pull request
Sep 23, 2017
Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Stephen Henson <steve@openssl.org> (Merged from #4405)
|
This is totally cherry-pick-able to 1.1.0. I meas suggestion is to cherry-pick this to 1.1.0 and just close #4404. |
dot-asm
added
approval: done
|
But wait for travis... |
Well, it's kind of meaningless request, because travis won't run 1.1.0 tests. Sorry about confusion. What I was alarmed by was that https://travis-ci.org/openssl/openssl/branches suggests that #4406 triggers some problem in extended tests, and it looks as if this request "adds" failure in 1st test... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically it is a reflection of key in s_client.c: https://github.com/openssl/openssl/blob/master/apps/s_client.c#L626