Move contributing info to CONTRIBUTING #444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Development is coordinated on the openssl-dev mailing list (see | ||
| http://www.openssl.org for information on subscribing). If you | ||
| would like to submit a patch, send it to openssl-bugs@openssl.org with |
There was a problem hiding this comment.
I'd make that email address "rt@openssl.org" for consistency
Manishearth
force-pushed
the
contribute
branch
from
e350d61
to
6b29926
Compare
| textual explanation of what your patch does. | ||
|
|
||
| You can also make GitHub pull requests. If you do this, please also send | ||
| mail to rt@openssl.org with a link to the PR so that we can more easily |
There was a problem hiding this comment.
Lets make that "with a brief description and a link"
There was a problem hiding this comment.
(fixed)
Should I myself send an updated description for the other PR I sent to the list, or is it fine for now?
Manishearth
force-pushed
the
contribute
branch
from
6b29926
to
b8e6161
Compare
|
+1 |
| # cd .. | ||
| # diff -ur openssl-orig openssl-work > mydiffs.patch | ||
|
|
||
| See https://github.com/openssl/openssl/blob/master/CONTRIBUTING |
There was a problem hiding this comment.
Hmmm, I understand your though, but I think that it should either be
See CONTRIBUTING
or we should move CONTRIBUTING somewhere completely different, such as wiki.openssl.org.
For now, I would prefer the former.
Manishearth
force-pushed
the
contribute
branch
from
b8e6161
to
daeaf7c
Compare
|
+1 |
mcr
pushed a commit
to mcr/openssl
that referenced
this pull request
Jun 22, 2021
…-setters pkey: remove deprecated parameter setters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README is long and doesn't immediately indicate that there is a procedure to follow for pull requests. Moving it out to CONTRIBUTING (where most projects put "how to contribute" information) makes it easier to find. Github also puts up a banner when making pull requests when there is a contributing file that hasn't been read.
I also updated the coding style link and added the blurb about "pull requests are okay however please email rt@" which was missing from the section.