Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify return values for EVP_DigestVerifyFinal. #446

Closed
wants to merge 1 commit into from

Conversation

aeijdenberg
Copy link
Contributor

Previous language was unclear. New language isn't pretty but I believe
it is more accurate.

@benlaurie
Copy link
Contributor

+1

@richsalz
Copy link
Contributor

How about this instead?

EVP_DigestVerifyFinal() returns 1 for success; any other value indicates failure.  A return
value of zero indicates that the signature did not verify successfully (that is, tbs did not
match the original data or the signature had an invalid form), while other values to indicate
a more serious error (and sometimes also indicate an invalid signature form).

Previous language was unclear.  New language isn't pretty but I believe
it is more accurate.
@aeijdenberg
Copy link
Contributor Author

Changed as suggested by Rich (with one minor change, removed extraneous "to").

@levitte
Copy link
Member

levitte commented Oct 22, 2015

+1

@richsalz
Copy link
Contributor

done in master and 1.0.2; thanks.

@richsalz richsalz closed this Oct 22, 2015
@levitte
Copy link
Member

levitte commented Oct 22, 2015

Any reason why not 1.0.1?

@richsalz
Copy link
Contributor

oops. and 1.0.1

@levitte
Copy link
Member

levitte commented Oct 23, 2015

Thanks :-)

@aeijdenberg aeijdenberg deleted the docfix branch October 26, 2015 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants