Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4459 "issuserAltName" documentation typo. #4460

Closed
wants to merge 1 commit into from
Closed

Fixes #4459 "issuserAltName" documentation typo. #4460

wants to merge 1 commit into from

Conversation

asiplas
Copy link
Contributor

@asiplas asiplas commented Oct 4, 2017

See crypto/objects/objects.txt:767 -- field is "issuerAltName"

Checklist
  • documentation is added or updated

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Oct 4, 2017
@dot-asm
Copy link
Contributor

dot-asm commented Oct 4, 2017

I'd argue that it's trivial change. In which case you'd be advised to add CLA: trivial line to commit message and force push.

@asiplas
Fixes #4459 "issuserAltName" documentation typo.
2d28215 
See crypto/objects/objects.txt:767 -- field is "issuerAltName"
CLA: trivial
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Oct 4, 2017
@dot-asm dot-asm added the approval: review pending This pull request needs review by a committer label Oct 4, 2017
levitte
levitte approved these changes Oct 4, 2017
View reviewed changes
Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is a trivial change

@levitte levitte added 1.1.0 branch: master Merge to master branch approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 4, 2017
levitte pushed a commit that referenced this pull request Oct 5, 2017
@asiplas
Fixes #4459 "issuserAltName" documentation typo.
36cf10c 
See crypto/objects/objects.txt:767 -- field is "issuerAltName"
CLA: trivial

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #4460)
@dot-asm
Copy link
Contributor

dot-asm commented Oct 5, 2017

Merged. Thanks.

@dot-asm dot-asm closed this Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@dot-asm dot-asm dot-asm approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asiplas @dot-asm @levitte @openssl-machine