Add 'rand' algorithm to speed tool #4481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richsalz
suggested changes
Oct 7, 2017
apps/speed.c
Outdated
| loopargs_t *tempargs = *(loopargs_t **) args; | ||
| unsigned char *buf = tempargs->buf; | ||
| int count; | ||
| for (count = 0; COND(c[D_RAND][testnum]); count++) |
There was a problem hiding this comment.
blank line after declarations
Signed-off-by: Patrick Steuer <patrick.steuer@de.ibm.com>
|
added speed(1) update. i chose 'rand' to be consistent with the openssl rand tool. |
paulidale
reviewed
Oct 8, 2017
| @@ -20,7 +20,8 @@ B<openssl speed> | |||
|
|
|||
| This command is used to test the performance of cryptographic algorithms. | |||
| To see the list of supported algorithms, use the I<list --digest-commands> | |||
| or I<list --cipher-commands> command. | |||
| or I<list --cipher-commands> command. The global CSPRNG is denoted by | |||
| I<rand>. | |||
There was a problem hiding this comment.
by the rand algorithm name.
|
We've got multiple different DRBGs now, might it make sense to parameterise this option to allow each to be chosen individually? |
|
For now they're just different instances of all the same algorithm, so i think parameterization is more than we need. |
paulidale
approved these changes
Oct 8, 2017
richsalz
approved these changes
Oct 9, 2017
richsalz
added
the
approval: done
|
I made the wording change to the doc and merged. Thanks! |
levitte
pushed a commit
that referenced
this pull request
Oct 10, 2017
Signed-off-by: Patrick Steuer <patrick.steuer@de.ibm.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #4481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Id like to be able to measure DRBG performance using the speed tool.
Heres a suggestion.