Revert "Add padding spaces before printing algo." #4745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test files need to be updated. This reverts commit 26a374a.
t-j-h
approved these changes
Nov 15, 2017
|
Thanks, pushed. Leaving open since maybe we can get help on the test_x509 failure (output of the cyrillic cert) |
|
I think this is the wrong fix. The right fix would have been this: diff --git a/test/certs/cyrillic.msb b/test/certs/cyrillic.msb
index 87f76cb0b0..ec58ac9b2f 100644
--- a/test/certs/cyrillic.msb
+++ b/test/certs/cyrillic.msb
@@ -3,7 +3,7 @@ Certificate:
Version: 3 (0x2)
Serial Number:
be:47:3c:53:a6:2a:c0:3a
- Signature Algorithm: sha256WithRSAEncryption
+ Signature Algorithm: sha256WithRSAEncryption
Issuer: C=RU, ST=\U041C\U043E\U0441\U043A\U0432\U0430, L=\U041C\U043E\U0441\U043A\U0432\U0430, O=\U0414\U043C\U0438\U0442\U0440\U0438\U0439 \U0411\U0435\U043B\U044F\U0432\U0441\U043A\U0438\U0439, OU=\U042F, CN=Dmitry Belyavskiy, emailAddress=beldmit@example.com
Validity
Not Before: Feb 21 19:35:22 2017 GMT
diff --git a/test/certs/cyrillic.utf8 b/test/certs/cyrillic.utf8
index 6eda733fa7..2096e4fb35 100644
--- a/test/certs/cyrillic.utf8
+++ b/test/certs/cyrillic.utf8
@@ -3,7 +3,7 @@ Certificate:
Version: 3 (0x2)
Serial Number:
be:47:3c:53:a6:2a:c0:3a
- Signature Algorithm: sha256WithRSAEncryption
+ Signature Algorithm: sha256WithRSAEncryption
Issuer: C=RU, ST=Москва, L=Москва, O=Дмитрий Белявский, OU=Я, CN=Dmitry Belyavskiy, emailAddress=beldmit@example.com
Validity
Not Before: Feb 21 19:35:22 2017 GMT |
|
I tried that and had utf8/output errors. Maybe it was pilot error. I'll try that later and push to this PR if it works. Thank you! |
|
I just tried it. Worked like a charm. I just noticed, btw, that a similar change is needed for the CRL output. I'm lining up a PR as we speak. |
|
Great, thanks for picking this up. I'll close this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test files need to be updated.
This reverts commit 26a374a.
@beldmit can you give me updated test files for the cyrillic test?