test suite nits #4873
Closed
test suite nits #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid memory leaks in error paths, and correctly apply parentheses to function calls in a long if-chain.
There's no reason to wrap this call in TEST_true() if we're not checking the return value of TEST_true() -- all of the surrounding similar calls do not have the macro wrapping them.
make_dummy_resp() uses OCSP types, and get_cert_and_key() is unused once make_dummy_resp() is compiled out, so neither can be included in the build when OCSP is disabled and strict warnings are active.
s_client -status is not available in this configuration.
mattcaswell
requested changes
Dec 8, 2017
| return NULL; | ||
| goto err; | ||
| bs_out = bs; | ||
| bs = NULL; |
There was a problem hiding this comment.
Presumably the point of this is so that we can free bs if an error occurs - but I don't see that happening anywhere
mattcaswell
reviewed
Dec 8, 2017
test/recipes/70-test_tls13messages.t
Outdated
| #Test 5: A status_request handshake (client and server) | ||
| #TODO(TLS1.3): TLS1.3 doesn't actually have CertificateStatus messages. This is | ||
| #a temporary test until such time as we do proper TLS1.3 style certificate | ||
| #status |
There was a problem hiding this comment.
Maybe not in scope of this PR but this TODO is now out of date. It can be removed.
There was a problem hiding this comment.
It's easy enough to remove it while I'm touching the code already. Plus it gets rid of a too-long line!
Per Matt's review. To be squashed, but the action noted in the resulting commit message.
mattcaswell
approved these changes
Dec 8, 2017
mattcaswell
added
the
approval: done
levitte
pushed a commit
that referenced
this pull request
Dec 8, 2017
Avoid memory leaks in error paths, and correctly apply parentheses to function calls in a long if-chain. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #4873)
levitte
pushed a commit
that referenced
this pull request
Dec 8, 2017
There's no reason to wrap this call in TEST_true() if we're not checking the return value of TEST_true() -- all of the surrounding similar calls do not have the macro wrapping them. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #4873)
levitte
pushed a commit
that referenced
this pull request
Dec 8, 2017
make_dummy_resp() uses OCSP types, and get_cert_and_key() is unused once make_dummy_resp() is compiled out, so neither can be included in the build when OCSP is disabled and strict warnings are active. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #4873)
levitte
pushed a commit
that referenced
this pull request
Dec 8, 2017
s_client -status is not available in this configuration. While here, remove an outdated TODO(TLS1.3) comment. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #4873)
|
Pushed to master; closing. |
Closed
kaduk
added a commit
to kaduk/openssl
that referenced
this pull request
Dec 8, 2017
Avoid memory leaks in error paths, and correctly apply parentheses to function calls in a long if-chain. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl#4873) (cherry picked from commit b6306d8)
kaduk
added a commit
to kaduk/openssl
that referenced
this pull request
Dec 8, 2017
make_dummy_resp() uses OCSP types, and get_cert_and_key() is unused once make_dummy_resp() is compiled out, so neither can be included in the build when OCSP is disabled and strict warnings are active. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl#4873) (cherry picked from commit cb09129)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues spotted by coverity and unbreak no-ocsp
@levitte the failure mode for the no-ocsp enable-tls1_3 mode is pretty poor, as s_client gives usage() but s_server keeps running, so the test suite appears to hang. Is there something more systematic we should be doing as well?