Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the ARIA ciphers by default. #4950

Closed
wants to merge 1 commit into from
Closed

Conversation

paulidale
Copy link
Contributor

Enable ARIA.
Remove the enable-aria options from the extended tests.

levitte pushed a commit that referenced this pull request Dec 17, 2017
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #4950)
@paulidale
Copy link
Contributor Author

Thanks for the quick approval. Merged.

@paulidale paulidale closed this Dec 17, 2017
@richsalz
Copy link
Contributor

I didn't look, but does no-aria config option work?

@kaduk
Copy link
Contributor

kaduk commented Dec 18, 2017

I generally like to see commit messages that mention the "why" of a change, as well as the "what" (since the "what" can be deduced from the changes itself, but the "why" can easily be lost to the winds of time).

@paulidale paulidale deleted the aria branch December 18, 2017 03:47
@dot-asm
Copy link
Contributor

dot-asm commented Dec 18, 2017

And I'd like to hear what has changed. See even new comment in #4741.

@paulidale
Copy link
Contributor Author

@kaduk fair suggestion. I added after messages from @richsalz and @t-j-h suggesting I do so and advising me of a policy decision that new ciphers be on by default but not in the TLS DEFAULT list.

@richsalz the no-aria option works.

@kroeckx
Copy link
Member

kroeckx commented Dec 18, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants