apps/speed.c: let EVP_Update_loop_ccm behave more like EVP_Update_loop #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-steuer
commented
Feb 2, 2018
apps/speed.c
Outdated
| * CCM does not support streaming. For the purpose of performance measurement, | ||
| * each message is encrypted using the same (key,iv)-pair. Do not use this | ||
| * code in your application. | ||
| */ |
There was a problem hiding this comment.
I removed this warning because it would be much needed in other places also. Having it only here kind of seems to imply that all other speed tool code is "best practice", which is not true e.g., just resetting counter w/o changing key/iv in generic update loop ...
|
This needs a rebase. @p-steuer, are you still around and willing? |
Signed-off-by: Patrick Steuer <patrick.steuer@de.ibm.com>
|
Im still around. Rebased and -f pushed. |
levitte
approved these changes
Jun 21, 2018
levitte
added
the
approval: review pending
|
Ping for second reviewer |
t-j-h
approved these changes
Jul 12, 2018
levitte
added
approval: done
|
Merged. 7da84e0 apps/speed.c: let EVP_Update_loop_ccm behave more like EVP_Update_loop |
levitte
pushed a commit
that referenced
this pull request
Jul 12, 2018
Signed-off-by: Patrick Steuer <patrick.steuer@de.ibm.com> Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #5246)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for my commits fe4f66d which states
This is not true when no aad is processed (which is actually the case for speed tool) because the length is set implicitely. An explicit reset of the length field is needed anyway for speed tool because with the current ccm implementation, the length field is destroyed during update operation (which is okay, since ccm interfaces are to be called once per packet. If the length field was not overwritten, ccm would not need its own loop in speed tool, edit: the last statement is only true for the encrypt case).
This patch makes ccm's update loop behave more like the generic update loop.