New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix versioned GCC detection #552
Conversation
When using versioned GCC executables (e.g. gcc-5, gcc-6, ...) running "make depend" fails because $ecc is compared to the "gcc" string (without version) when setting the MAKEDEPPROG variable. Also, since now $ecc will be just "gcc", simplify the --strict-warnings check.
Running |
@levitte yes, but with the recent build changes we always get the "you must run make depend" message even on Travis: https://travis-ci.org/openssl/openssl/jobs/102411115#L6185 Maybe it's a separate bug... |
Also, IIRC @richsalz mentioned somewhere that running "make depend" is mandatory now (or did I just imagine it?), maybe I should have asked him instead :) |
We are a bit over the top there, it's true... I did see it as mandatory just a few days ago, but then realised that for those who just download, unpack, build, test and install and then don't touch it any more, that's strictly speaking not true. ... I'm way too sleepy to do anything about it now, but if noone gets there before me, I might think of some way to reword that "error" message tomorrow... |
What really is mandatory is to run |
Ok, thanks. We might still want to run it on Travis for testing purposes though (e.g. doing that wold have caught the error I got when running make depend with |
@ekasper hmmm, you are right, I don't remember my original thought process, I guess I was just too quick to jump to conclusions, sorry :/ |
@levitte ping? should I just remove the "make depend on Travis" commit? |
wait a bit for my "remove clean-depend" change to land, and let's see if this is still needed. |
This is fixed in master now. |
Basically this fixes "make depend" when using e.g. "CC=gcc-5" and also makes Travis run "make depend".