Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build failure with CIPHER_DEBUG #559

Closed
wants to merge 1 commit into from
Closed

Fix build failure with CIPHER_DEBUG #559

wants to merge 1 commit into from

Conversation

ghedo
Copy link
Contributor

@ghedo ghedo commented Jan 16, 2016

No description provided.

@richsalz
Copy link
Contributor

Remove the first one, and keep this just to CIPHER_DEBUG, please.

@ghedo
Copy link
Contributor Author

ghedo commented Jan 16, 2016

You mean the second one? (the Apple thing)

@richsalz
Copy link
Contributor

Yeah, makeit just about cipher_debug.

@ghedo
Copy link
Contributor Author

ghedo commented Jan 16, 2016

Ok, done.

@richsalz
Copy link
Contributor

+1

@richsalz
Copy link
Contributor

So @kroeckx says that it was broken by dropping support DH cipher suites in
bc71f91 and he thinks it should be fixed, not removed.

@ghedo ghedo changed the title Ifdef cleanup Fix build failure with CIPHER_DEBUG Jan 19, 2016
@ghedo
Copy link
Contributor Author

ghedo commented Jan 19, 2016

@richsalz I don't really agree with keeping CIPHER_DEBUG, but I updated the PR to simply fix the build failure for now and changed the PR title.

@richsalz
Copy link
Contributor

+1 from me.
@kroeckx, you want to review and merge?

@kroeckx
Copy link
Member

kroeckx commented Jan 22, 2016

+1

@richsalz
Copy link
Contributor

commit b7557cc thanks.

@richsalz richsalz closed this Jan 22, 2016
@ghedo ghedo deleted the ifdef_clean branch January 27, 2016 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ghedo @richsalz @kroeckx