Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a crash in error handing of rand_drbg_new #5646

Closed
wants to merge 1 commit into from
Closed

Fixed a crash in error handing of rand_drbg_new #5646

wants to merge 1 commit into from

Conversation

bernd-edlinger
Copy link
Member

No description provided.

@bernd-edlinger bernd-edlinger added the branch: master Merge to master branch label Mar 16, 2018
mspncp
mspncp approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@mspncp mspncp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, thanks for noticing!

One question for curiosity: what caused the allocation failure? Was it triggered by a testsuite?

@mspncp mspncp added the approval: review pending This pull request needs review by a committer label Mar 16, 2018
@mspncp mspncp added this to the 1.1.1 milestone Mar 16, 2018
@bernd-edlinger
Copy link
Member Author

That is a stress test with random memory error injection that I occasionally execute.

@kroeckx kroeckx added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Mar 16, 2018
@bernd-edlinger
Copy link
Member Author

Merged, thanks!

levitte pushed a commit that referenced this pull request Mar 17, 2018
@bernd-edlinger
Fixed a crash in error handing of rand_drbg_new
f96ff4e 
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
(Merged from #5646)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroeckx kroeckx kroeckx approved these changes

@kaduk kaduk kaduk approved these changes

@mspncp mspncp mspncp approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bernd-edlinger @kroeckx @kaduk @mspncp