Documentation typo fix in EVP_EncryptInit.pod #5792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl-machine
added
the
hold: cla required
mattcaswell
reviewed
Mar 29, 2018
doc/man3/EVP_EncryptInit.pod
Outdated
| @@ -100,7 +100,6 @@ EVP_enc_null | |||
| int EVP_CIPHER_nid(const EVP_CIPHER *e); | |||
| int EVP_CIPHER_block_size(const EVP_CIPHER *e); | |||
| int EVP_CIPHER_key_length(const EVP_CIPHER *e) | |||
| int EVP_CIPHER_key_length(const EVP_CIPHER *e); | |||
There was a problem hiding this comment.
Probably it would be better to remove the one without the ; on the end!
|
Please update your commit comment with the text "CLA: Trivial" on a separate line. Assuming you agree that this change is trivial from a copyright perspective and therefore you don't need to sign the CLA. |
richsalz
approved these changes
Mar 29, 2018
Remove duplicate declaration of `EVP_CIPHER_key_length` in the synopsis. CLA: trivial
openssl-machine
removed
the
hold: cla required
dot-asm
approved these changes
Apr 1, 2018
dot-asm
added
the
approval: done
|
Merged to master, thanks for the fix! |
levitte
pushed a commit
that referenced
this pull request
Apr 2, 2018
Remove duplicate declaration of `EVP_CIPHER_key_length` in the synopsis. CLA: trivial Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #5792)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate declaration of
EVP_CIPHER_key_lengthin the synopsis.Checklist
N/A