Minor corrections for the RAND_DRBG API documentation #5804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mspncp
commented
Mar 29, 2018
|
|
||
| The method L<RAND_DRBG_bytes(3)> is a convenience method wrapping the | ||
| L<RAND_DRBG_generate(3)> function, which serves the actual request for | ||
| random data. |
There was a problem hiding this comment.
At some time in the past, this line served as explanation for the caption <ssl->drbg> ==> RAND_DRBG_bytes(ssl->drbg, ...) in the image above. Now since that caption disappeared together with the per-ssl DRBG, this single line was orphaned and appeared to be a bit misplaced.
- added some explaining text to a sentence that lost its context. - removed mention of per-ssl drbg - fix whitespace errors
mspncp
force-pushed
the
pr-minor-corrections-for-rand-drbg-documentation
branch
from
7a1c75a
to
239ae10
Compare
mspncp
changed the title
mspncp
added
the
approval: review pending
|
ping |
richsalz
approved these changes
Apr 11, 2018
mspncp
added
approval: done
|
Merge, thanks! |
levitte
pushed a commit
that referenced
this pull request
Apr 11, 2018
- added some explaining text to a sentence that lost its context. - removed mention of per-ssl drbg - fix whitespace errors Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #5804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It did not take long until I found the first mistake after merging the RAND_DRBG API documentation (#5461). Here is the first correction:
Instead of pushing micro-fixes I will let this pull request hang around for a while in case more errors show up. All fixes will finally be squashed into a single commit.Errata can be posted here, too. I will fix them.Update: Squashed and ready for final review.