Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in x509 documentation #5829

Closed
wants to merge 1 commit into from
Closed

fix typo in x509 documentation #5829

wants to merge 1 commit into from

Conversation

iluxonchik
Copy link
Contributor

@iluxonchik iluxonchik commented Mar 31, 2018 •
edited

Checklist
  • documentation is added or updated

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Mar 31, 2018
richsalz
richsalz approved these changes Mar 31, 2018
View reviewed changes
Copy link
Contributor

@richsalz richsalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sign our CLA? If you prefer, edit your comment message (git commit --amend / git push -f ) to add "CLA: trivial" on a line by itself in your text. Thanks!

@iluxonchik
Copy link
Contributor Author

@richsalz sure. To which e-mail should I send the CLA to?

@richsalz
Copy link
Contributor

richsalz commented Apr 1, 2018

Get them here: https://www.openssl.org/policies/cla.html and the CLA says to mail to legal@opensslfoundation.org thank you.

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Apr 1, 2018
@iluxonchik
Copy link
Contributor Author

iluxonchik commented Apr 1, 2018 •
edited

@richsalz oh thank you, you're right.

CLA sent. Please, check your spam folder, as it might be marked as such.

@richsalz
Copy link
Contributor

richsalz commented Apr 1, 2018

close/open to kick the CLA bot.

@richsalz richsalz closed this Apr 1, 2018
@richsalz richsalz reopened this Apr 1, 2018
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Apr 1, 2018
@dot-asm dot-asm added the approval: done This pull request has the required number of approvals label Apr 1, 2018
levitte pushed a commit that referenced this pull request Apr 2, 2018
@iluxonchik
fix typo in x509 documentation
d53df3d 
Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #5829)
@richsalz
Copy link
Contributor

richsalz commented Apr 2, 2018

Merged to master, thanks!

@richsalz richsalz closed this Apr 2, 2018
@iluxonchik
Copy link
Contributor Author

@richsalz you're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richsalz richsalz richsalz approved these changes

@dot-asm dot-asm dot-asm approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iluxonchik @richsalz @dot-asm @openssl-machine