Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use getenv for critical functions when run as setuid/setgid #5856

Closed
wants to merge 4 commits into from
Closed

Don't use getenv for critical functions when run as setuid/setgid #5856

wants to merge 4 commits into from

Conversation

bernd-edlinger
Copy link
Member

No description provided.

@mattcaswell
Copy link
Member

Should this be documented somewhere? Is this just for master?

@bernd-edlinger
Copy link
Member Author

Good, point, will add some documentation.

@bernd-edlinger
Copy link
Member Author

It is inspired by the automatic configuration thing...
This does not cherry-pick, but I feel like I should do something
about the active branches as well.

@bernd-edlinger
Copy link
Member Author

I can't find where it is documented what OPENSSL_CONF does in libcrypto.
It is documented in man pages about the openssl command, but that is something
different.

@mattcaswell
Copy link
Member

It should probably be somewhere on this page:

https://github.com/openssl/openssl/blob/master/doc/man5/config.pod

Probably also here:

https://github.com/openssl/openssl/blob/master/doc/man3/OPENSSL_config.pod

@bernd-edlinger
Copy link
Member Author

I have also concerns about windows. OPENSSL_issetugid is just a dummy there.
When there is no distributor, automatically loading something where an environemnt
value points to will do more harm than to helps.

@bernd-edlinger
Copy link
Member Author

Documentation added.

@mattcaswell
Copy link
Member

Looks good. Since this is a behavioural change I think an entry in CHANGES is probably a good idea too.

@bernd-edlinger
Copy link
Member Author

Ok, done.

@bernd-edlinger
Copy link
Member Author

I'll assume @levitte's approval is still valid since only documentation changes were added.

@bernd-edlinger bernd-edlinger added the approval: done This pull request has the required number of approvals label Apr 4, 2018
levitte pushed a commit that referenced this pull request Apr 4, 2018
@bernd-edlinger
Don't use getenv for critical functions when run as setuid/setgid
284f4f6 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #5856)
@bernd-edlinger
Copy link
Member Author

Merged to master as 284f4f6
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bernd-edlinger @mattcaswell @levitte