RT4272: Unit tests fail when DTLS disabled #589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing SKIP: block in SSL unit tests for DTLS and TLS version tests.
|
Quite right! |
mattcaswell
added
the
approval: done
|
+1...@levitte will you push? |
|
Sure |
|
Aaaand pushed. |
|
(hmmm, not quite in the habit yet... who closes this PR, @tmshort or me?) |
|
I normally do it, or @tmshort. Whoever gets there first. |
|
thanks guys! |
|
Either can close it, but since you did the work you should close it. The original submitter should close it if they're "withdrawing" it. |
|
Thanks for the explanations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing SKIP: block in SSL unit tests for DTLS and TLS version tests.