Rethink regression fixes done in 1.1.0 #5947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A reminder to anyone wanting to try a regression test: |
levitte
force-pushed
the
rethink-regression-fixes-110-2
branch
from
5092e90
to
f95dee5
Compare
levitte
force-pushed
the
rethink-regression-fixes-110-2
branch
from
f95dee5
to
818c4f0
Compare
t-j-h
approved these changes
Apr 29, 2018
|
You asked for comments on this over in #5661 (comment) I think this should be closed. If we find issues in 1.1.0/1.1.1 interop stuff, we can look at this again. |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some changes in 1.1.0 to mitigate against regression errors when re-linking with 1.1.1 libssl. Those changes suggest that we cannot upgrade OpenSSL 1.1.0 to 1.1.1 without changes. This is wrong and is therefore reverted.