Update version docs (1.1.0) #6014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear that you should not attempt to get the version before the first handshake is complete. Fixes openssl#2893
levitte
requested changes
Apr 19, 2018
doc/ssl/SSL_get_version.pod
Outdated
| @@ -17,6 +17,10 @@ SSL_get_version, SSL_is_dtls - get the protocol information of a connection | |||
| SSL_get_version() returns the name of the protocol used for the | |||
| connection B<ssl>. | |||
|
|
|||
| The above function should only be called after the intial handshake has been | |||
| completed. Prior to that the results returned from this function may be | |||
| unreliable. | |||
There was a problem hiding this comment.
Same comment here as for the 1.0.2 PR
levitte
approved these changes
Apr 20, 2018
|
Updated with same wording change as #6013. |
richsalz
added
the
approval: done
levitte
approved these changes
Apr 27, 2018
|
Pushed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear that you should not attempt to get the version before the
first handshake is complete.
Fixes #2893
This is the 1.1.0 version of #6013.
Checklist