Fix a warning about missing prototype on arm #6028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richsalz
approved these changes
Apr 19, 2018
mspncp
reviewed
Apr 19, 2018
| @@ -74,6 +74,8 @@ FILE *openssl_fopen(const char *filename, const char *mode); | |||
| void *openssl_fopen(const char *filename, const char *mode); | |||
| # endif | |||
|
|
|||
| unsigned long OPENSSL_rdtsc(void); | |||
There was a problem hiding this comment.
Wasn't it decided in #4757 after a lengthy discussion that this should consistently be a uint32_t? (see db26a403b4de69d7846656362e70f5083428)
There was a problem hiding this comment.
Maybe as another PR. This PR is just trying the fix the --strict-warnings build.
There are likely more issues, for instance sparcv9cap.c
defines "unsigned long OPENSSL_rdtsc(void)" without including "internal/cryptlib.h" first.
levitte
pushed a commit
that referenced
this pull request
Apr 20, 2018
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #6028)
|
Merged to 1.1.0 |
romen
pushed a commit
to romen/openssl
that referenced
this pull request
Mar 6, 2019
(Merged from openssl#6028) (cherry picked from commit 5fc89c1)
romen
pushed a commit
to romen/openssl
that referenced
this pull request
Apr 30, 2019
(Merged from openssl#6028) (cherry picked from commit 5fc89c1)
romen
pushed a commit
to romen/openssl
that referenced
this pull request
Jun 11, 2019
(Merged from openssl#6028) (cherry picked from commit 5fc89c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.