Clarify BN_mod_exp docs #6137
Closed
Clarify BN_mod_exp docs #6137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically this is not supported with an even modulus and BN_FLG_CONSTTIME. Fixes openssl#5082
mattcaswell
added
branch: master
2 tasks
richsalz
suggested changes
Apr 30, 2018
doc/man3/BN_add.pod
Outdated
| @@ -92,7 +92,9 @@ BN_exp() raises I<a> to the I<p>-th power and places the result in I<r> | |||
| BN_mul(). | |||
|
|
|||
| BN_mod_exp() computes I<a> to the I<p>-th power modulo I<m> (C<r=a^p % | |||
| m>). This function uses less time and space than BN_exp(). | |||
| m>). This function uses less time and space than BN_exp(). Note that calling | |||
There was a problem hiding this comment.
"not supported" doesn't mean much. Does it return an error? Perhaps this:
Do not call this function when B<m> is even and any of the parameters have the B<BN_FLG_CONSTTIME> flag set.
|
Fixup commit pushed. The same fixup has also been applied to #6138. |
richsalz
approved these changes
May 1, 2018
|
Pushed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically this is not supported with an even modulus and
BN_FLG_CONSTTIME.
Fixes #5082