Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: add pair of linux-ppc64le targets. #6192

Closed
wants to merge 4 commits into from

Conversation

dot-asm
Copy link
Contributor

@dot-asm dot-asm commented May 7, 2018

WIP, no approval requested. Second commit that removes most targets will be removed prior approval is requested. The request will be closed and reopened couple of times in order to get some timing statistics.

@dot-asm
Copy link
Contributor Author

dot-asm commented May 7, 2018

It's about 2 minutes provisioning time. There is no support ccache-ing. There is ccache, but cache is not offloaded, so there is no gain. As result non-extended test build is couple of minutes slower than it could have been. One can also observe several minutes variation, as if jobs are scheduled to less and more busy systems, unbalanced that is. Extended test can take >30 minutes (if you happen to run on apparently more busy system). This is >2x slower that than tests on x86_64. One can wonder if this can have some kind of serializing effect on queue, because if it does, then push-to-repo queue could get unbearably slow during bursts...

@dot-asm
Copy link
Contributor Author

dot-asm commented May 7, 2018

Extended test adds between 30 to 50[!] minutes of additional CPU time. I'd say this is a bit excessive. I therefore would rather suggest to keep one non-extended --strict-warning build and keep sanitizer build commented for occasions when there is reason to believe that there is PPC-specific problem that can be troubleshooted with sanitizer... Removing WIP...

@dot-asm dot-asm changed the title WIP: .travis.yml: add pair of linux-ppc64le targets. .travis.yml: add pair of linux-ppc64le targets. May 7, 2018
.travis.yml Outdated
@@ -109,6 +113,12 @@ matrix:
- gcc-mingw-w64
compiler: x86_64-w64-mingw32-gcc
env: EXTENDED_TEST="yes" CONFIG_OPTS="no-pic"
# Uncomment if there is reason to believe that PPC-specific problem
# can be diagnosed with with possibly >30 mins sanitizer build...
Copy link
Contributor

@FdaSilvaYY FdaSilvaYY May 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" can be diagnosed with with possibly " ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. Thanks!

Andy Polyakov added 3 commits May 9, 2018 12:30
One is clang --strict-warnings and one gcc sanitizer extended test.
--strict-warnings build masks couple of warnings and intention is
to address them separately. Sanitizer build is quite expensive, can
take >30 mins and is commented for occasions when there is reason to
believe that PPC-specific problem can be diagnosed with sanitizer.
Idea is to have them started earlier, so that non-extended test
doesn't have to be waited out each time.
@dot-asm
Copy link
Contributor Author

dot-asm commented May 9, 2018

Re-based and ready to roll.

@richsalz richsalz added the approval: done This pull request has the required number of approvals label May 9, 2018
levitte pushed a commit that referenced this pull request May 10, 2018
One is clang --strict-warnings and one gcc sanitizer extended test.
Sanitizer build is quite expensive, can take >30 mins and is commented
for occasions when there is reason to believe that PPC-specific problem
can be diagnosed with sanitizer.

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #6192)
@dot-asm dot-asm closed this May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants