STORE: split off the description of the 'file' scheme loader #6350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a quick recommendation on how to name loader docmentation.
levitte
added
branch: master
|
Ping? |
|
Just in case for reference. I'm in general reluctant to approve things like documentation, because of lack of linguistic skills. I try to look for and point out factual wrongs or things that are not clear to me, but I try to abstain from approvals. In other words me not saying something in situation like this request rather means that I didn't spot something wrong :-) |
|
Cool. So with that, does anyone else want to approve? |
richsalz
approved these changes
Jun 1, 2018
richsalz
added
the
approval: done
|
Thank you! |
|
Merged. 166f008 STORE: split off the description of the 'file' scheme loader |
levitte
added a commit
that referenced
this pull request
Jun 1, 2018
This includes a quick recommendation on how to name loader docmentation. Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #6350)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a quick recommendation on how to name loader docmentation.