test/evp_test.c: address sanitizer errors in pderive_test_run. #6614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dot-asm
commented
Jun 29, 2018
dot-asm
commented
- tests are added or updated
richsalz
previously approved these changes
Jun 29, 2018
richsalz
added
the
approval: done
|
Well, the problem is specific to 1.1.0, as master can handle data-less errors. So no, don't replicate it for #6608. This does mean that I could solve the 1.1.0 problem by fixing the evp_test.c instead... One can probably argue that it would be more appropriate... |
dot-asm
force-pushed
the
evptests.txt-110
branch
from
feaa843
to
99ee3dc
Compare
dot-asm
removed
the
approval: done
dot-asm
changed the title
dot-asm
dismissed
richsalz’s stale review
Solved in evp_test.c instead, it's more appropriate...
|
Re-review [of alternative solution] is required. [Red cross from coveralls is insignificant fluctuation.] |
richsalz
approved these changes
Jul 1, 2018
levitte
pushed a commit
that referenced
this pull request
Jul 2, 2018
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #6614)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.