Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip over early_data if we sent an HRR #6737

Closed

Conversation

mattcaswell
Copy link
Member

It is not valid to send early_data after an HRR has been received.

Fixes #6734

@mattcaswell mattcaswell added branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch labels Jul 18, 2018
@mattcaswell mattcaswell added this to the 1.1.1 milestone Jul 18, 2018
Copy link
Contributor

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, verified as fixed with script from #6734

@richsalz richsalz added the approval: done This pull request has the required number of approvals label Jul 18, 2018
@mattcaswell
Copy link
Member Author

Pushed. Thanks.

levitte pushed a commit that referenced this pull request Jul 19, 2018
It is not valid to send early_data after an HRR has been received.

Fixes #6734

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #6737)
levitte pushed a commit that referenced this pull request Jul 19, 2018
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #6737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants